[Patch-gnuradio] gnuradio-core/src/lib/general/gr_crc32.h

[Dan Halperin]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

The prototype

        unsigned int gr_crc32(const unsigned char *buf, int len);
(gr_crc32.h:40)

does not match the function definition

        unsigned int gr_crc32(const unsigned char *buf, size_t len)

in the .cc file, which causes problems when attempting to link it into
other modules. I propose changing the header file to size_t.

Also, this function is not exposed via the .i file. What's the reasoning
behind this?

Thanks,

Dan

patch:


Index: gr_crc32.h
===================================================================
- --- gr_crc32.h  (revision 4710)
+++ gr_crc32.h  (working copy)
@@ -37,7 +37,7 @@
 unsigned int gr_update_crc32(unsigned int crc, const unsigned char
*buf, int len);
 unsigned int gr_update_crc32(unsigned int crc, const std::string buf);

- -unsigned int gr_crc32(const unsigned char *buf, int len);
+unsigned int gr_crc32(const unsigned char *buf, size_t len);
 unsigned int gr_crc32(const std::string buf);

 #endif /* INCLUDED_CRC32_H */
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGooEHy9GYuuMoUJ4RAko7AJ0RhSM+wCBSfrMTcGJnLROU0FBNMQCfYKHt
5KC4d7ZYwE+oIul76h54Q8w=
=Hhyv
-----END PGP SIGNATURE-----