Re: [Pan-users] Various possible bug fixes

[Duncan]

Andrew Nile posted on Wed, 19 Mar 2014 23:06:43 +0000 as excerpted:

> Hi Heinrich, looks great. My patches in the first post turned out quite
> a bit messy and hard to follow, sorry. :( Two tiny things though, line
> 1996 of header-pane.cc should also be changed to
> 
> _bg(prefs.get_color_str_wo_fallback ("text-color-bg"))
> 
> so that the background colour is fixed, and the new_color_button code in
> group-prefs-dialog.cc (line 246) doesn't seem right. This is the code
> between the braces in my copy:
> 
> ===
> 
> const PanColors& colors (PanColors::get());
> const std::string& def_fg (colors.def_fg);
> const std::string& fg (prefs.get_color_str("group-pane-color-fg",
> def_fg));
> const GdkColor& val (gprefs.get_group_color (group, fg));
> 
> GtkWidget * b = gtk_color_button_new_with_color (&val);
> g_signal_connect (b, "color-set", G_CALLBACK(color_set_cb), dialog);
> 
> return b;
> 
> ===
> 
> Replacing the code in git with the above should work as intended. :)

This build-error (gcc 4.8.2) would seem to be related:

group-prefs-dialog.cc: In function 'GtkWidget* 
{anonymous}::new_color_button(const pan::Quark&, pan::Prefs&, 
pan::GroupPrefs&, pan::GroupPrefsDialog*, GtkWidget*)':
group-prefs-dialog.cc:249:55: error: 'val' was not declared in this scope
     GtkWidget * b = gtk_color_button_new_with_color (&val);
                                                       ^
group-prefs-dialog.cc:251:32: error: 'colors' was not declared in this 
scope
     const std::string& def_fg (colors.def_fg);
                                ^
Makefile:619: recipe for target 'group-prefs-dialog.o' failed
make[3]: *** [group-prefs-dialog.o] Error 1
make[3]: *** Waiting for unfinished jobs....


> I found another colour related thing. In body-pane.cc, if you move lines
> 540-543 to the top of that code block (line 509) then the quote level
> colours work again by applying the text colour first.

I've not tried it (yet? I'm hoping Heinrich makes my manual trial 
unnecessary =:^), but getting quote colors working again would sure be 
nice! =:^)


Meanwhile, staring at the build output the following warning about 
unsigned int vs long unsigned int also concerns me.  Tho it could well 
have been there for awhile and I've just not looked until now, thus 
making it likely unrelated to the latest changes.

post-ui.cc: In member function 'void pan::PostUI::update_filequeue_label
(GtkTreeSelection*)':
post-ui.cc:163:124: warning: format '%u' expects argument of type 
'unsigned int', but argument 4 has type 
'std::vector<pan::Task*>::size_type {aka long unsigned int}' [-Wformat=]
     g_snprintf(str,sizeof(str), _("Upload queue: %u tasks, %ld KB (~ 
%.2f MB) total."), tasks.size(), kb, kb/1024.0f);

[There's a ^ after 124 spaces, which pan doesn't wrap correctly so I 
deleted it and the spaces.]

-- 
Duncan - List replies preferred.   No HTML msgs.
"Every nonfree program has a lord, a master --
and if you use the program, he is your master."  Richard Stallman