hi,
and one more improvement.
since the BYE and CANCEL requests must not have a Contact header, according to RFC 3261
Header field where proxy ACK BYE CAN INV OPT REG
___________________________________________________________
Contact R o - - m o o
eXosip should NOT add a Contact header to these requests.
my suggestion is (jrequest.c, ~ line 984):
instead of
i = _eXosip_request_add_via (excontext, request, transport, locip);
if (i != 0) {
osip_message_free (request);
return i;
}
/* add specific headers for each kind of request... */
_eXosip_dialog_add_contact (excontext, request, NULL);
I would write:
i = _eXosip_request_add_via (excontext, request, transport, locip);
if (i != 0) {
osip_message_free (request);
return i;
}
/* add specific headers for each kind of request... */
if ((0 != strcmp ("BYE", method)) &&
(0 != strcmp ("CANCEL", method)))
{
// BYE and CANCEL must not have a Contact-header
_eXosip_dialog_add_contact (excontext, request, NULL);
}
br,
christoph