Re: [Oroborus-user] New version 2.0.6

[Stefan Pfetzing]

* Chris Osgood <address@hidden> [020712 18:27]:
> No, that version still crashes.  I "fixed" my version by checking the
> return value of XGetClassHint.  I say "fixed" because even with that
> change it crashed one time.  I have not been able to get it to repeat
> though.  I noticed that there are lots of XGet--- calls that do not check
> the return value for failure.  My guess is there is more than one area
> where something similar is happening.
Well that seems like it *CAN'T* be... because the version I sent you looks
just like:

int
clientInBorderlessList (Client * c)
{
  XClassHint *class_res;
  char *win_class_name;
  char *tok;
  char *buf;
  size_t strSize;

#ifdef DEBUG
  printf ("entering clientInBorderlessList\n");
#endif

  class_res = xmalloc (sizeof (XClassHint));

  class_res->res_name = NULL;

  if (XGetClassHint (dpy, c->window, class_res) && class_res->res_name)
    win_class_name = class_res->res_name;
  else
    {
      XFree (class_res);
      return False;
    }

  strSize = sizeof (char) * (strlen (borderless_windows) + 1);
  buf = xmalloc (strSize);
  snprintf (buf, strSize, "%s", borderless_windows);

  tok = strtok (buf, ";");

  while (tok)
    {
      if (strcasecmp (tok, win_class_name) == 0)
        {
          XFree (class_res);
          free (buf);
          return True;
        }
      tok = strtok (NULL, ";");
    }

  XFree (class_res);
  free (buf);
  return False;
}


bye

Stefan

-- 
        http://www.dreamind.de/
Oroborus and Debian GNU/Linux Developer.