[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Openvortex-dev] Re: au8810 support patch

From: Manuel Jander
Subject: [Openvortex-dev] Re: au8810 support patch
Date: Mon, 05 May 2003 20:45:54 -0400
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3) Gecko/20030327 Debian/1.3-4

Hi Jeff,

Sorry for the patch without discussion. Pontus Fuchs was just so happy with
his AU8810 working, so i decided to just apply it, after i tested my AU8820 and AU8830
working correctly after patching on my local tree.

Jeff Muizelaar wrote:

What is the reason for this patch? Everything else looks good.

diff -u -r1.11 -r1.12
--- openvortex/alsa/pci/au88x0/au88x0.c 2003/05/05 01:21:38     1.11
+++ openvortex/alsa/pci/au88x0/au88x0.c 2003/05/05 05:52:37     1.12
@@ -18,6 +18,7 @@
#include <linux/init.h>
#include <linux/pci.h>
#include <linux/slab.h>
+#include <linux/interrupt.h>

This include ... dont know really. I think we could remove it. Maybe useful for
linux-2.5 ? Pontus ... what can you tell about ?

#define SNDRV_GET_ID
#include <sound/initval.h>

@@ -142,7 +143,6 @@
        goto irq_out;
    chip->irq = pci->irq;
-    vortex_enable_int(chip);

    // End of PCI setup.
@@ -272,6 +272,7 @@
    // (7)
    pci_set_drvdata(pci, chip);
+    vortex_enable_int(chip);
    return 0;

Moving the Interrupt enable ... really not needed. Maybe we should put it back since it doesn't matter if it is done later and it would be nicer to have it near
the interrupt requesting code.

Manuel Jander.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]