octave-patch-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #10016] [octave forge] (statistics) mhsamp


From: Philip Nienhuis
Subject: [Octave-patch-tracker] [patch #10016] [octave forge] (statistics) mhsample implementation (over from bug #59924)
Date: Sat, 30 Jan 2021 15:04:41 -0500 (EST)
User-agent: Mozilla/5.0 (Windows NT 6.1; rv:52.0) Gecko/20100101 Firefox/52.0

Update of patch #10016 (project octave):

                  Status:                    None => In Progress            
             Assigned to:                    None => philipnienhuis         

    _______________________________________________________

Follow-up Comment #14:

Nice work. Good adherence to GNU coding style, tests, demo.
Thanks very much!

I tried it out and found this:

Demo 1 gives a nice plot; nice!

-but:-

Demo 2 shows nothing ... no plot, no output. In addition it relies on the
'heaviside' function which is in the symbolic package. This implies adding a
dependence on the symbolic package for the sake of just a demo. I don't think
this is desirable.
Can you please come up with another 2nd demo? (or just drop it)

Once you have this sorted out I think I can push it.
Next then I'll probably push a few minor style & texinfo fixes - I'm sometimes
a nitpicker, though surely not the most fanatical one out here :-)

Would you like to be credited for this contribution (well-deserved IMO)? In
that case I can push it at least under your name, your email isn't required.
We do need your name then.

(BTW your email can be handy for in case we get bug reports or other issues;
but I don't know a secure way to keep it private.
It's easy to create an account here ("New user"), only a nickname and a valid
email address is required. Visitors can't see it but unfortunately any
registered Savannah user can.)


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?10016>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]