octave-patch-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #9998] C++ Implementation of matlab.lang.m


From: Markus Mützel
Subject: [Octave-patch-tracker] [patch #9998] C++ Implementation of matlab.lang.makeValidName
Date: Fri, 20 Nov 2020 12:51:30 -0500 (EST)
User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.198 Safari/537.36 Edg/86.0.622.69

Follow-up Comment #1, patch #9998 (project octave):

I haven't tested the patches yet. But some nitpicky remarks regarding the
style:
* Indentation of "{ }" blocks seems to be off sometimes.
* Spaces at lambda expressions should be like in "[] (arg1, arg2) { body; }".
* Lines shouldn't end with an opening bracket.
* Class members should start with "m_".

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?9998>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]