[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-patch-tracker] [patch #9980] JSON encoder and decoder, alternati
From: |
Philip Nienhuis |
Subject: |
[Octave-patch-tracker] [patch #9980] JSON encoder and decoder, alternative to object2json |
Date: |
Sun, 1 Nov 2020 09:06:39 -0500 (EST) |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; rv:52.0) Gecko/20100101 Firefox/52.0 |
Follow-up Comment #34, patch #9980 (project octave):
OK.
Note that your email is still in the functions themselves.
I've uploaded them here with the following changes:
* Fixed & reorganized texinfo so that info is somewhat more organized per
subject / input arg. I hope you like it. Fixing Texinfo issues often boils
down to adding "@" before offending characters ("@" is a Texinfo control char)
and I use the on-line Texinfo docs:
https://www.gnu.org/software/texinfo/manual/texinfo/texinfo.html
* Dropped caution at end of texinfo. I think we shouldn't refer to functions
in future Octave releases (jsonencode/jsondecode are in 7.x which will be
released maybe only later next year) or the proprietary competition in any
way.
* Updated copyright strings
* Prepended warning- / error messages with function name.
and apart from minor typos and Octave's editor removing whitespace after each
line, that's it.
For convenience I've also uploaded "diff -u" diffs to see what got changed.
There are still smaller style things (spaces between function arguments/after
comma's, between function name and opening parenthesis, double rather than
single quotes where possible) but I'm not going to chase that all down.
As I wrote in my first comment here: on the whole I think you've done a very
good job.
If you want to make some last edits, here's your chance. If (when) you are
satisfied I'll push them, just let me know.
(file #50178, file #50179, file #50180, file #50181)
_______________________________________________________
Additional Item Attachment:
File name: fromJSON.m Size:20 KB
<https://file.savannah.gnu.org/file/fromJSON.m?file_id=50178>
File name: toJSON.m Size:18 KB
<https://file.savannah.gnu.org/file/toJSON.m?file_id=50179>
File name: fromJSON.diff Size:13 KB
<https://file.savannah.gnu.org/file/fromJSON.diff?file_id=50180>
File name: toJSON.diff Size:11 KB
<https://file.savannah.gnu.org/file/toJSON.diff?file_id=50181>
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/patch/?9980>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
- [Octave-patch-tracker] [patch #9980] JSON encoder and decoder, alternative to object2json,
Philip Nienhuis <=
- [Octave-patch-tracker] [patch #9980] JSON encoder and decoder, alternative to object2json, anonymous, 2020/11/01
- [Octave-patch-tracker] [patch #9980] JSON encoder and decoder, alternative to object2json, Philip Nienhuis, 2020/11/01
- [Octave-patch-tracker] [patch #9980] JSON encoder and decoder, alternative to object2json, anonymous, 2020/11/02
- [Octave-patch-tracker] [patch #9980] JSON encoder and decoder, alternative to object2json, Markus Mützel, 2020/11/07
- [Octave-patch-tracker] [patch #9980] JSON encoder and decoder, alternative to object2json, anonymous, 2020/11/07
- [Octave-patch-tracker] [patch #9980] JSON encoder and decoder, alternative to object2json, Markus Mützel, 2020/11/07
- [Octave-patch-tracker] [patch #9980] JSON encoder and decoder, alternative to object2json, Philip Nienhuis, 2020/11/07