octave-patch-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #9897] Implement the missing ordqz functio


From: Markus Mützel
Subject: [Octave-patch-tracker] [patch #9897] Implement the missing ordqz function.
Date: Thu, 22 Oct 2020 14:53:47 -0400 (EDT)
User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.80 Safari/537.36 Edg/86.0.622.48

Update of patch #9897 (project octave):

                  Status:          Ready For Test => Need Info              

    _______________________________________________________

Follow-up Comment #8:

Thank you for your contribution.
I slightly adapted the coding style (mostly white spaces and double quotes
instead of single quotes) and added a commit message. Please, see the attached
patch.

The last test is failing for me:

>> A = magic (5);
B = hilb (5);
[AA, BB, Q, Z] = qz (A, B);
[AAS, BBS, QS, ZS] = ordqz (AA, BB, Q, Z, "rhp");
E2 = ordeig (AAS, BBS);
ECOMP = [2.887137073068260e+06; 4.873038494509828e+02; 4.363814079693997e+01;
-2.573723338161374e+04; -8.557816814087249e+02];
assert (norm (ECOMP - E2, "Inf"), 0, 1e-8);

error: ASSERT errors for:  assert (norm (ECOMP - E2, "Inf"),0,1e-8)

  Location  |  Observed  |  Expected  |  Reason
     ()       5.7407e-06       0         Abs err 5.7407e-06 exceeds tol 1e-08
by 6e-06


Is this just an accuracy issue and the tolerance should be increased? Or is
there something more to it?

When this is fixed, it like to push this patch. Would you like to be added to
the list of contributors?

(file #50054)
    _______________________________________________________

Additional Item Attachment:

File name: patch9897_ordqz_v2.patch       Size:25 KB
   
<https://file.savannah.gnu.org/file/patch9897_ordqz_v2.patch?file_id=50054>



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?9897>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]