[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #9976] Missing function: freqspace

From: anonymous
Subject: [Octave-patch-tracker] [patch #9976] Missing function: freqspace
Date: Mon, 28 Sep 2020 18:25:55 -0400 (EDT)
User-agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:80.0) Gecko/20100101 Firefox/80.0

Follow-up Comment #2, patch #9976 (project octave):

Thanks for the quick feedback.

I noticed that I'd misread the Matlab documentation:  The inputs need to be
given as [M,N].  I've fixed this in the attached file (v2).

Style fixes:

- [ ] No use of `end`, use `endif`, etc.
- [ ] No use of `~=`, use `!=`
- [ ] No more than 79 chars per line
- [ ] Leave a space between variables and operators
  DONE - With the exception of one use of max() within a list.  Adding a space
there would result in an error.
- [ ] Adapt docstring to latest standards
  OPEN - Not sure what's needed here.  I don't have any good examples to add
to show the use of the function.  (I wrote it to make some old code work that
was originally written for Matlab, but its use of freqspace was very basic.)

General necessities:

- [ ] No tests (BIST)
  DONE - Added some basic tests.  Not exhaustive though.
- [ ] No Mercurial patch (NEWS entry, module.mk entries, etc.)
  OPEN - Not sure what's needed here.

General questions:

- [ ] Do you want to be publicly listed as Octave contributor?
  I'm already listed (from a few contributions many years ago).
- [ ] Matlab offers only support for two 2D outputs, your function seems to be
N-dimensional.  Are there real use cases justifying the more complicated
  Don't know.  In my use-case I only need 1-D functionality.  If it needs to
be restricted to 2-D then applying a check on the number of input/output
arguments would be an easy way to limit it, but would allow a user to edit the
m-file to restore N-D functionality very easily if they wanted.
(I tend to work with 3-D / 4-D (i.e. time varying) medical images, and I've
sometimes found it frustrating if functions are limited to 2-D.  So I usually
try to write N-D code where it makes sense, even if I'm not aware of a
use-case at the time.)

(file #49879)

Additional Item Attachment:

File name: freqspace_v2.m                 Size:5 KB


Reply to this item at:


  Message sent via Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]