[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #9976] Missing function: freqspace

From: Kai Torben Ohlhus
Subject: [Octave-patch-tracker] [patch #9976] Missing function: freqspace
Date: Mon, 28 Sep 2020 05:39:39 -0400 (EDT)
User-agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/85.0.4183.121 Safari/537.36

Update of patch #9976 (project octave):

                  Status:                    None => Need Info              
                 Summary: Missing function:  freqspace => Missing function:


Follow-up Comment #1:

Thank you for your contribution, they are always welcome.

Are you interested in adapting your code to the Octave style guide?


As many maintainers are busy, it might take some time until someone catches up
your great work.

First of all, your function does what it says.  Some observations before I
would consider your function to be ready for inclusion into Octave core. 
Maybe a look at the code of meshgrid might give a good orientation what is
left to do


Style fixes:

- [ ] No use of `end`, use `endif`, etc.
- [ ] No use of `~=`, use `!=`
- [ ] No more than 79 chars per line
- [ ] Leave a space between variables and operators
- [ ] Adapt docstring to latest standards

General necessities:

- [ ] No tests (BIST)
- [ ] No Mercurial patch (NEWS entry, module.mk entries, etc.)

General questions:

- [ ] Do you want to be publicly listed as Octave contributor?
- [ ] Matlab offers only support for two 2D outputs, your function seems to be
N-dimensional.  Are there real use cases justifying the more complicated


Reply to this item at:


  Message sent via Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]