[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #9930] [octave forge] (statistics) boxplot

From: Philip Nienhuis
Subject: [Octave-patch-tracker] [patch #9930] [octave forge] (statistics) boxplot function with extended features
Date: Fri, 19 Jun 2020 09:07:15 -0400 (EDT)
User-agent: Mozilla/5.0 (Windows NT 6.1; rv:52.0) Gecko/20100101 Firefox/52.0

Update of patch #9930 (project octave):

                  Status:             In Progress => Ready For Test         


Follow-up Comment #14:

here is what I made of it:
* boxplot.m
* patch (diff -u) relative to your latest version
* cset relative to repo.

what I did:

0  Add "Colors" argument - I found just yellow fill a bit dull :-)
0  Add two demos to show color options
0  Simplify the switch statement - switch / case also accept character or
cellstr values
0  Made input validation a lot stricter - always first check for proper
type/class, only then for acceptable values
0  Add about 28 tests for proper operation of input validation
0  Add two tests for proper (basic) operation of boxplot
0  Improved a few comments
0  Made OutlierTags accept numeric 0 or 1 as well
0  Polish the texinfo a bit
0  Threw out the outermost if blocks in the plot section, as plot() also works
if plot_opts is empty
0  Made the fill section a separate subfunction (required for Colors argument

As you can see, input validation is now a large part of the code. That often
happens, especially if input args accept both numeric and character values.

I don't claim it's perfect now, not at all; but it does adhere better to
Octave code quality standards.

Would you please try the newest boxplot.m and report if there are any issues?
I'll wait a week or so before I'l push it to the repo anyway.

(file #49315, file #49316, file #49317)

Additional Item Attachment:

File name: boxplot.diff                   Size:29 KB

File name: boxplot.cset                   Size:30 KB

File name: boxplot.m                      Size:32 KB


Reply to this item at:


  Message sent via Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]