octave-patch-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #9880] pkg describe provides dependency in


From: Rik
Subject: [Octave-patch-tracker] [patch #9880] pkg describe provides dependency information
Date: Thu, 2 Jan 2020 14:18:58 -0500 (EST)
User-agent: Mozilla/5.0 (Windows NT 10.0; WOW64; Trident/7.0; rv:11.0) like Gecko

Update of patch #9880 (project octave):

                  Status:          Ready For Test => Done                   
             Open/Closed:                    Open => Closed                 

    _______________________________________________________

Follow-up Comment #3:

This seems like a very useful addition to pkg.  I committed the patch here:
https://hg.savannah.gnu.org/hgweb/octave/rev/c8a44a4e4fe7.

I made two small modifications.  First, I split the very long line that
formats the package dependencies in to two lines of code for readability.


pkg_deps = cellfun (@(d) sprintf ("%s %s %s", struct2cell (d){:}), pkg_deps,
                    "UniformOutput", false);
pkg_deps = strjoin (pkg_deps, "\n\t");


Second, I removed an apparently unnecessary call to strtrim on the output of
strjoin.

@Philip: "non-essential dependencies" might be an interesting feature.  I
would file a Feature Request report about it, rather than continuing with this
patch report.

Marking as Done and closing report.


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?9880>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]