[Octave-patch-tracker] [patch #9360] image package: new function otsuthresh.m

[Hartmut]

Follow-up Comment #8, patch #9360 (project octave):

I have had another closer look at this patch (file #40868). Here are my
comments:
* There is a wrong character in the first lines, the last character in the
first name of Carne.
* You could add a check to reject sparse inputs, Matlab claims to reject
them.
* Several tests do not do what they pretend to do! For example this code "H =
zeros(1,2,'int32'); H = [100 200];" does NOT give a vector of class uint32,
but a vector of class double! So most of the integer input classes are
untested.
* I have tried all integer input classes that Matlab claims to support. The
following do NOT work: int8, int32, int64, uint32, uint64. Most of them don't
work because "imcast" cannot deal with them.

@Avinoam: Could you fix this? 

To get full coverage of all Matlab compatible input classes we would probably
need to change imcast as well. Or can we live with an otsuthresh, that can
only deal with the most common integer classes (the following already work:
uint8, uint16, int16).

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?9360>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/