octave-patch-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #8801] add support for the histogram and h


From: Mike Miller
Subject: [Octave-patch-tracker] [patch #8801] add support for the histogram and histcounts functions
Date: Thu, 6 Sep 2018 14:02:04 -0400 (EDT)
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:62.0) Gecko/20100101 Firefox/62.0

Follow-up Comment #6, patch #8801 (project octave):

The histcounts function should be in Octave, in the scripts/statistics
directory just as the patch makes it.

The summary line of the doc string for histcounts should probably mention the
input variable X (e.g. "Compute histogram bin counts for the data array
@var{x}").

The second paragraph starting with "Input arguments: X ..." and the last
paragraph starting with "Output arguments: N ..." do not fit with Octave doc
string style.

There are some code style issues (extra or missing space before or after
parentheses, missing parentheses on "switch" argument, missing parentheses
around complex logical conditions). There are a couple of trailing spaces in
the doc string block that should be deleted.

The test suite is buggy, running it repeatedly causes failures in some of the
tests that rely on random input data. I haven't looked into it to see whether
this is a bug in the test formulation or a bug in the histcounts function
itself.

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?8801>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]