octave-patch-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #9448] image package: new function imfindc


From: Hartmut
Subject: [Octave-patch-tracker] [patch #9448] image package: new function imfindcircles.m
Date: Fri, 12 Jan 2018 15:59:26 -0500 (EST)
User-agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0

Follow-up Comment #4, patch #9448 (project octave):

I have only had the chance for a short look at your code changes, yet. Some
things have popped to my eyes so far:
(Sorry, I didn't manage to leave comments directly in your bitbucket repo.)

* There is a typo somewhere: "directions late ron."
* I think the function imhmax(f, h) can be fully deleted in the code of
imfindcircles.
* The function imregionalmax(img) can also be deleted inside the code of
imfindcircles.
* The last section (visualize the found circles in the image) in the !demo
code can be re-written much nicer now, because imviscircles is implemented.
(It should turn into roughly a one-liner.)
* Do the tests all still pass?


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?9448>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]