[Octave-patch-tracker] [patch #9281] Image package: imsharpen

[Hartmut]

Follow-up Comment #1, patch #9281 (project octave):

Thanks for this new function.

Some comments from my side:

* One test is (slightly) failing. Should we make it an xtest? (This depends on
Carne's preference how to deal with those cases.)

* I get some texinfo errors on "help imsharpen": The "item" bullet points seem
to be used outside of their intended context. And there might also be some
missing curly brackets in the help text.

* line 54: There seems to be a copy and paste error, this error messages
claims to be throughn by "impyramid".

* line 106,107: Is this clipping of L to the interval [0,100] Matlab
compatible? (My experience from implementing the color conversion functions
is, that Matlab normally does not clip, but just returns useless results. But
I haven't checked the Matlab behavior in this very case.)

* some (one?) additional test with useful input images of class uint8 might be
good. For example: A=zeros(7,7,'unit8'); A(4,4)=30; imsharpen(A);

* I am no expert on coding guidelines in the image package. But the missing
identation of function blocks (2 space signes per line) popped to my eye.
There might be more code style issues.

* line 62-65: The calculation of imsharpen_size looks funny. Is this Matlab
compatible? Could you add a test for this (somehow)?

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?9281>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/