[Octave-patch-tracker] [patch #8960] Preliminary balancing and balance option for eig

[Carnë Draug]

Follow-up Comment #11, patch #8960 (project octave):

I was hoping you come to IRC today too. It's nice that you removed the
duplication of the code, it is much better now.

However, the tests still don't test the real thing, i.e., that the expected
algorithm is used instead of another. The tests should check for that, it's
the whole point of this options. Let's imagine that in a few weeks, someone
makes a change on the code that ignores the setting of chol, or balance. The
tests must identify that regression.

How to write tests for that? Think why would you set qz or chol? Why would you
set balance or nobalance? What would be the difference in those cases?  Then
write tests for that.

Also, I don't understand the purpose of this change
https://bitbucket.org/BarbaraLocsi/octave/commits/2f0e9b4815d49be65a834075d64e2b7ead214b6c
and your commit message doesn't mention anything.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8960>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/