|
From: | Carnë Draug |
Subject: | [Octave-patch-tracker] [patch #8837] normest1 |
Date: | Tue, 26 Jul 2016 11:33:00 +0000 (UTC) |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0 |
Follow-up Comment #19, patch #8837 (project octave): I have pushed http://hg.savannah.gnu.org/hgweb/octave/rev/bfb1b089c230 as discussed on IRC. I noticed that none of the tests in normest1 check the value of k. Could you add tests for that? One other thing is that k is a row or column vector depending on the code path took (it's a row vector if ((n <= 4) || (t == n))). I understand that this is Matlab compatible but is also obviously a Matlab bug. Does anyone has an opinion about making it always one or the other? And if so, which? A row or a column vector? _______________________________________________________ Reply to this item at: <http://savannah.gnu.org/patch/?8837> _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/
[Prev in Thread] | Current Thread | [Next in Thread] |