[Octave-patch-tracker] [patch #9057] Octave Mapping package: majaxis and minaxis

[Philip Nienhuis]

Follow-up Comment #4, patch #9057 (project octave):

_<savannah markup bit me again>_

<cont. from comment #3>


function a=majaxis(b, e)
  ## The equation is b=a*√(1-e^2)
  ## rearranging a=b/√(1-e^2)
  a = b / sqrt(1 - e ^ 2);
  endfunction


should rather look like

function a = majaxis (b, e)

  ## The equation is b=a*√(1-e^2)
  ## rearranging a=b/√(1-e^2)
  a = b / sqrt (1 - e ^ 2);

endfunction



Also in the texinfo help text, spaces Octave's coding style is appreciated for
better readability. 

Immediately after the deftypefn line there should be a on-line brief
description of what the function is used for - one sees that when typing "help
majaxis".

In addition error checks are needed. What will happen if b = 0? b and/or e <
1, or non-numeric?

And of course tests are needed.

BTW are you the same person that also contributed patches 9051 and 9053?


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?9057>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/