|
From: | Carnë Draug |
Subject: | [Octave-patch-tracker] [patch #9047] Array constructor from std sequence containers |
Date: | Fri, 15 Jul 2016 14:49:12 +0000 (UTC) |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0 |
Follow-up Comment #1, patch #9047 (project octave): My main problems with this patch are: 0 it is coded in the header (alternatively, we could declare a set of containers but I think this is better so it can support any class that looks like a std sequence container) 0 repeats a very small snippet from Array 0 the for loop takes a reference to the values which is kinda pointless in a vector of ints but may mean less copying for complex objects _______________________________________________________ Reply to this item at: <http://savannah.gnu.org/patch/?9047> _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/
[Prev in Thread] | Current Thread | [Next in Thread] |