octave-patch-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #8872] add isocaps


From: Markus Mützel
Subject: [Octave-patch-tracker] [patch #8872] add isocaps
Date: Fri, 8 Jul 2016 15:45:31 +0000 (UTC)
User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:48.0) Gecko/20100101 Firefox/48.0

Follow-up Comment #6, patch #8872 (project octave):

Thank you, Lachlan, for reviewing that patch.

You did raise some valid points. All of your concerns should be addressed in
the attached changeset.

I tried to improve the docstring but this is hard for me because English is
not my native language. All I could come up with is:
"This function places caps at open ends of isosurfaces."
which makes the first two sentences of the docsting a little bit redundant.

Could you please run the demo (which I added in favor of the poor example)?
That should make clearer what this function actually does.
Maybe, you could find some better word for "end-caps" or describe better what
is ment.

Wrt the other patches: As much as I would like to get all of them into 4.2, I
see that this is probably hard taking into acount that there is only one week
left before feature freeze.

Since you asked, here is a list with some of the patches starting with the
easier/smaller (but imho nevertheless useful) ones which I think should
reviewed first if time permits:
1- patch #9040 "lighting": That is mostly the same as "shading" with added
changes from bug #48392.
2- patch #8864 "smooth3": Mainly just a wrapper for convn.
3- patch #8856 "reducevolume": No magic at all. Most complicated part was to
get the input right.
4- patch #8912 "reducepatch": A little bit more complex but something I use
quite frequently.
5- patch #9014 "camlight": None of "my" patches but something I'd very much
like to see included.
6- patch #9013 "material": Something I added "for the sake of completeness".
Should not contain anything harmful but quite low on my list.
7- This patch #8872 "isocaps" since you already started reviewing.

Other patches need probably more time to get pushable and won't be ready for
4.2.0.

Another piece of code that I would find helpful is Pantxo's file #33886 from
patch #11311.

This list is probably quite excessive. If we could get at least some of these
patches into 4.2, it would be really nice.

The latest changeset in patch #8943 ("light") is mainly error fixes and can
probably still be applied after feature freeze. The same holds maybe for most
(or some) part of patch #8901 (the infamous "fminsearch" one). But the latter
with lower priority.

(file #37773)
    _______________________________________________________

Additional Item Attachment:

File name: isocaps_v2.patch               Size:20 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8872>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]