octave-patch-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #8901] fminsearch support for more options


From: Lachlan Andrew
Subject: [Octave-patch-tracker] [patch #8901] fminsearch support for more options and more output arguments
Date: Wed, 6 Jul 2016 13:43:01 +0000 (UTC)
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:43.0) Gecko/20100101 Firefox/43.0

Follow-up Comment #2, patch #8901 (project octave):

Markus, in general it is good to submit patches for bugs on the bug tracker. 
The patch tracker doesn't get looked at much, and is mainly for new features
that aren't bug fixes.

Is there a need to have a single patch addressing two bugs?  It is easier to
maintain if each patch addresses a single bug.  That also allows the standard
format for the first line of the commit message:


Description of change (bug #.....)


If possible, could you please split this patch into the part that fixes each
bug, and submit the parts under the different bug reports?

I'm not sure why you attached both fminsearch.patch and fminsearch.m.  Is the
.m version the file once the patch has been applied?

If the extra bug that the patch fixes is small, the in is probably OK just to
document it in the comments of one of the other bug reports.  However, if it
is substantial, then it should have its own report.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8901>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]