[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #8856] add function reducevolume

From: Markus Mützel
Subject: [Octave-patch-tracker] [patch #8856] add function reducevolume
Date: Thu, 14 Jan 2016 11:40:14 +0000
User-agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:44.0) Gecko/20100101 Firefox/44.0

Follow-up Comment #2, patch #8856 (project octave):

Thank you for your prompt and kind comments.

Like you suggested, I added a some more help text with simple examples for the
usage. I hope it is understandable and not too confusing.

Additionally, I added some tests for the different usage scenarios (number and
format of input and output arguments) and other tests triggering each of the
errors that can be reached. I did not find out how to do error test on more
than one line. Thus, the lines for these tests got a little "long-ish".

The subfunction for input validation checks for 3 or 6 input arguments because
the number of output arguments of the main function is passed as additional
first parameter. The main function itself must be called with 2 or 5 arguments
(like the original one in Matlab).

I hope I addressed all occurrances of code style issues.

Please, let me know how to proceed.

(file #36026)

Additional Item Attachment:

File name: reducevolume.m                 Size:10 KB


Reply to this item at:


  Nachricht gesendet von/durch Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]