octave-patch-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #8307] Add new ordschur function.


From: Mike Miller
Subject: [Octave-patch-tracker] [patch #8307] Add new ordschur function.
Date: Fri, 06 Feb 2015 14:25:47 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/40.0.2214.91 Safari/537.36

Update of patch #8307 (project octave):

                  Status:                    None => Need Info              
             Assigned to:                    None => mtmiller               

    _______________________________________________________

Follow-up Comment #4:

Thanks for the patch. I just took a very quick glance at this and it looks
mostly complete. Includes NEWS, doc changes, test cases, all good.

Is there a reason for putting this function in dldfcn? I think that is usually
used for functions that load larger external libraries that we don't want
linked into Octave all the time or that may be optional. This is just wrapping
LAPACK functions. Also the schur function is in corefcn. I think this should
be moved there also.

See also the thread at
http://octave.1599824.n4.nabble.com/Numerical-or-other-significant-code-in-DEFUN-functions-td4652573.html.
Jwe would prefer that numerical functions can be called in liboctave and the
interpreter binding be a wrapper around that. I'm not sure where the line is
or whether this function needs to be in liboctave or not. At the very least,
this function is a much thinner wrapper, just dispatching the given matrix
arguments to the appropriate LAPACK functions.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8307>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]