[Octave-patch-tracker] [patch #7964] Possible overflow in terminal buffer

[Dan Sebald]

Follow-up Comment #1, patch #7964 (project octave):

This post should have gone under "Bugs".  Patches are for non-bug related
items.

This definitely looks like a bug if "len" can be 4096. buf[len] would then be
one beyond the end of the buffer.  I'd say apply the patch as a quick
stopgap.

However, I don't know why a buffer size of 4096 is put on the stack.  A buffer
that size should be on the heap.  Putting a listener to sleep for thirty
seconds seems odd as well.  We try to not do such polling loop strategies,
especially on the listening side.  This should be done with signals/slots. 
I'm guessing the thirty second wait described in

https://savannah.gnu.org/patch/?7949

is related to this.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?7964>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/