[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-patch-tracker] [patch #7857] Replace dynamic casts of GUI/IDE ed
[Octave-patch-tracker] [patch #7857] Replace dynamic casts of GUI/IDE editor with more slots/signals configuration
Sun, 23 Dec 2012 20:51:30 +0000
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:22.214.171.124) Gecko/20111108 Fedora/3.6.24-1.fc14 Firefox/3.6.24
Follow-up Comment #27, patch #7857 (project octave):
I'm fine with making the external file change a separate patch. In fact, it
is probably best to have a good working version the first way, then a small
change for the second way. I could make the change, but unless I can verify
proper behavior either by some test on my system or by Qt documentation it
probably makes no sense to change it.
I've created a new patch with what I think are the things I touched in the
commit message. (Sure was a mess...must have reverted some changes you made
by forcing a forward commit.) This seems to restore desired behavior. Let me
know if it doesn't work correctly.
On Windows systems case is ignored? I sort of remember that for DOS, but I'd
have thought that was changed given that spaces were allowed in file names.
Let's make that a separate commit. I don't see that I altered anything with
"WINDOWS", etc. Mainly this patch is to get things more in line with
signals/slots and fix the few obvious problems with saving and opening files
in the editor.
Sorry this took a while. Octave has been somewhat unstable for a month or so
and I thought I'd wait for things to even out a bit.
Additional Item Attachment:
File name: octave-gui_no_casts-2012dec23.patch Size:76 KB
Reply to this item at:
Message sent via/by Savannah