Build failure on Mac: 'gui-preferences-nr.h' file not found

[Andrew Janke]

Hi, Octave folks,

I did a straightforward octave build from default like this on macOS
10.14.6 with Xcode 10.3:

hg clone https://www.octave.org/hg/octave
(cd octave; ./bootstrap)
git clone https://github.com/apjanke/octave-build
cd octave-build
mkdir build
cd build
mkdir ../logs
. ../configure_octave.sh &> ../logs/configure.log
make

And it broke:

/Applications/Xcode-10.3.app/Contents/Developer/usr/bin/make  all-recursive
Making all in libgnu
/Applications/Xcode-10.3.app/Contents/Developer/usr/bin/make  all-recursive
make[4]: Nothing to be done for `all-am'.
  CXX      libgui/src/libgui_src_la-main-window.lo
../../octave/libgui/src/main-window.cc:60:10: fatal error:
'gui-preferences-nr.h' file not found
#include "gui-preferences-nr.h"
         ^~~~~~~~~~~~~~~~~~~~~~
1 error generated.
make[2]: *** [libgui/src/libgui_src_la-main-window.lo] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2


$ make V=1     
rm -f bits/stl_algo.h
/Applications/Xcode-10.3.app/Contents/Developer/usr/bin/make  all-recursive
Making all in libgnu
/Applications/Xcode-10.3.app/Contents/Developer/usr/bin/make  all-recursive
make[4]: Nothing to be done for `all-am'.
/bin/sh ./libtool  --tag=CXX   --mode=compile clang++ -std=gnu++11
-DHAVE_CONFIG_H -I. -I../../octave  
-I/usr/local/opt/freetype/include/freetype2
-I/usr/local/Cellar/fontconfig/2.13.1/include
-I/usr/local/opt/freetype/include/freetype2
-I/usr/local/Cellar/qt/5.13.1/lib/QtNetwork.framework/Headers
-I/usr/local/Cellar/qt/5.13.1/lib/QtPrintSupport.framework/Headers
-I/usr/local/Cellar/qt/5.13.1/lib/QtHelp.framework/Headers
-I/usr/local/Cellar/qt/5.13.1/lib/QtWidgets.framework/Headers
-I/usr/local/Cellar/qt/5.13.1/lib/QtGui.framework/Headers
-I/usr/local/Cellar/qt/5.13.1/lib/QtSql.framework/Headers
-I/usr/local/Cellar/qt/5.13.1/lib/QtXml.framework/Headers
-I/usr/local/Cellar/qt/5.13.1/lib/QtCore.framework/Headers
-I../../octave/libgui/qterminal/libqterminal -Ilibgui/src
-I../../octave/libgui/src -I../../octave/libgui/src/m-editor -Iliboctave
-I../../octave/liboctave/array -Iliboctave/numeric
-I../../octave/liboctave/numeric -Iliboctave/operators
-I../../octave/liboctave/operators -I../../octave/liboctave/system
-I../../octave/liboctave/util -Ilibinterp -I../../octave/libinterp
-Ilibinterp/parse-tree -I../../octave/libinterp/parse-tree
-Ilibinterp/corefcn -I../../octave/libinterp/corefcn
-I../../octave/libinterp/octave-value -I../../octave/liboctave/wrappers
-I/usr/local/opt/qrupdate/include -I/usr/local/opt/qscintilla2/include
-I/usr/local/opt/qt/include -I/usr/local/opt/readline/include
-I/usr/local/opt/sundials/include -fPIC -D_THREAD_SAFE -pthread -Wall -W
-Wshadow -Woverloaded-virtual -Wold-style-cast -Wformat -Wpointer-arith
-Wwrite-strings -Wcast-align -Wcast-qual -g -O2 -MT
libgui/src/libgui_src_la-main-window.lo -MD -MP -MF
libgui/src/.deps/libgui_src_la-main-window.Tpo -c -o
libgui/src/libgui_src_la-main-window.lo `test -f
'libgui/src/main-window.cc' || echo
'../../octave/'`libgui/src/main-window.cc
libtool: compile:  clang++ -std=gnu++11 -DHAVE_CONFIG_H -I.
-I../../octave -I/usr/local/opt/freetype/include/freetype2
-I/usr/local/Cellar/fontconfig/2.13.1/include
-I/usr/local/opt/freetype/include/freetype2
-I/usr/local/Cellar/qt/5.13.1/lib/QtNetwork.framework/Headers
-I/usr/local/Cellar/qt/5.13.1/lib/QtPrintSupport.framework/Headers
-I/usr/local/Cellar/qt/5.13.1/lib/QtHelp.framework/Headers
-I/usr/local/Cellar/qt/5.13.1/lib/QtWidgets.framework/Headers
-I/usr/local/Cellar/qt/5.13.1/lib/QtGui.framework/Headers
-I/usr/local/Cellar/qt/5.13.1/lib/QtSql.framework/Headers
-I/usr/local/Cellar/qt/5.13.1/lib/QtXml.framework/Headers
-I/usr/local/Cellar/qt/5.13.1/lib/QtCore.framework/Headers
-I../../octave/libgui/qterminal/libqterminal -Ilibgui/src
-I../../octave/libgui/src -I../../octave/libgui/src/m-editor -Iliboctave
-I../../octave/liboctave/array -Iliboctave/numeric
-I../../octave/liboctave/numeric -Iliboctave/operators
-I../../octave/liboctave/operators -I../../octave/liboctave/system
-I../../octave/liboctave/util -Ilibinterp -I../../octave/libinterp
-Ilibinterp/parse-tree -I../../octave/libinterp/parse-tree
-Ilibinterp/corefcn -I../../octave/libinterp/corefcn
-I../../octave/libinterp/octave-value -I../../octave/liboctave/wrappers
-I/usr/local/opt/qrupdate/include -I/usr/local/opt/qscintilla2/include
-I/usr/local/opt/qt/include -I/usr/local/opt/readline/include
-I/usr/local/opt/sundials/include -fPIC -D_THREAD_SAFE -pthread -Wall -W
-Wshadow -Woverloaded-virtual -Wold-style-cast -Wformat -Wpointer-arith
-Wwrite-strings -Wcast-align -Wcast-qual -g -O2 -MT
libgui/src/libgui_src_la-main-window.lo -MD -MP -MF
libgui/src/.deps/libgui_src_la-main-window.Tpo -c
../../octave/libgui/src/main-window.cc  -fno-common -DPIC -o
libgui/src/.libs/libgui_src_la-main-window.o
../../octave/libgui/src/main-window.cc:60:10: fatal error:
'gui-preferences-nr.h' file not found
#include "gui-preferences-nr.h"
         ^~~~~~~~~~~~~~~~~~~~~~
1 error generated.
make[2]: *** [libgui/src/libgui_src_la-main-window.lo] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2


Anyone know what's up with this?

Cheers,
Andrew