[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: HAVE_FEATURE information for BLAS and LAPACK
From: |
Mike Miller |
Subject: |
Re: HAVE_FEATURE information for BLAS and LAPACK |
Date: |
Fri, 11 Oct 2019 11:46:53 -0700 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Fri, Oct 11, 2019 at 09:27:43 -0700, Rik wrote:
> This isn't at all true. BLAS and LAPACK are non-optional requirements and
> the configure script will bail out if early if they are not present. Since
> they are non-optional, one choice would be to remove them from the
> build_features structure. There is no need to test for them because they
> will always be there. Another simple choice would be to default these two
> entries to 1 since they will always be present. I have a slight leaning
> towards the first solution since I don't believe there is a reason for a
> programmer to condition any of their code on HAVE_BLAS or HAVE_LAPACK.
I think it would be simplest to add a regular expression filter in the
awk section of the mk-build-env-features script to specify HAVE_FOO
names that should be omitted from the output.
The only argument against this is that it's more maintenance burden to
remove HAVE_BLAS and HAVE_LAPACK than it is to keep them in. And this is
for an internal-use-only structure. But I am in favor of removing them
if it's reasonable.
--
mike
signature.asc
Description: PGP signature