Re: Review of windows package

[Markus Mützel]

Am 06. April 2019 um 13:49 Uhr schrieb "John Donoghue":
> Does any one have a little spare time to review the next version of the
> windows package on the release tracker?
>
> https://sourceforge.net/p/octave/package-releases/362/
>
> The current review checklist is
> https://wiki.octave.org/Reviewing_Octave-Forge_packages
>

To be honest I am not very familiar with Octave's package system and I don't 
know how to do a review.
This is what I did:
On Octave 6.0.0 (hg id: 7b03bc060dc7) unpacked from the 7z-dist file, I ran the 
following:
>> pkg install 
>> https://sourceforge.net/p/octave/package-releases/_discuss/thread/bdda9bfc44/5bdb/attachment/windows-1.3.1.tar.gz
For information about changes from previous versions of the windows package, 
run 'news windows'.

"news windows" displays fine. "pkg load windows" seems to work and "runtests 
D:\Repositories\Octave\test\octave-2019-04-06-15-42-w64\octave-2019-04-06-15-42-w64\mingw64\share\octave\packages\windows-1.3.1"
 reported that both BISTs succeeded.
"pkg unload windows" works.
However on uninstall, I see the following:
>> pkg uninstall windows
error: couldn't delete directory 
D:\Repositories\Octave\test\octave-2019-04-06-15-4
2-w64\octave-2019-04-06-15-42-w64\mingw64\share\octave\packages\windows-1.3.1: 
Directory not empty
error: called from
    uninstall at line 120 column 11
    pkg at line 490 column 7
But the directory is empty:
>> dir 
>> D:\Repositories\Octave\test\octave-2019-04-06-15-42-w64\octave-2019-04-06-15-42-w64\mingw64\share\octave\packages\windows-1.3.1
.   ..
I don't know whether this is specific to the package.
Should I run any further tests?


On Octave 5.1.0.0 installed with the official Windows installer, I couldn't 
install the package with the same command that succeeded with the self-compiled 
development version:
>> pkg -verbose install 
>> https://sourceforge.net/p/octave/package-releases/_discuss/thread/bdda9bfc44/5bdb/attachment/windows-1.3.1.tar.gz
mkdir (C:\Users\Markus\AppData\Local\Temp\oct-PEhJf8)
untar (C:\Users\Markus\AppData\Local\Temp\oct-9fRLSF\windows-1.3.1.tar.gz, 
C:\Users\Markus\AppData\Local\Temp\oct-PEhJf8)
./configure: line 1436: cannot create temp file for here-document: Permission 
denied
./configure: line 1448: cannot create temp file for here-document: Permission 
denied
./configure: line 1483: cannot create temp file for here-document: Permission 
denied
./configure: line 1645: cannot create temp file for here-document: Permission 
denied
./configure: line 1649: cannot create temp file for here-document: Permission 
denied
./configure: line 1653: cannot create temp file for here-document: Permission 
denied
./configure: line 1657: cannot create temp file for here-document: Permission 
denied
./configure: line 1661: cannot create temp file for here-document: Permission 
denied
./configure: line 1665: cannot create temp file for here-document: Permission 
denied
configure: loading site script /usr/local/etc/config.site
checking for gcc... gcc
./configure: line 2128: cannot create temp file for here-document: Permission 
denied
checking whether the C compiler works... no
sed: can't read conftest.c: No such file or directory
configure: error: in 
`/c/Users/Markus/AppData/Local/Temp/oct-PEhJf8/windows-1.3.1/src':
configure: error: C compiler cannot create executables
See `config.log' for more details

pkg: error running the configure script for windows.
error: called from
    configure_make at line 82 column 9
    install at line 184 column 7
    pkg at line 441 column 9
>>

However, I don't know whether I am doing the right thing.
Maybe this is because the folder that Octave is installed in seems to be 
protected by user account control on my system. If this is the case, I am 
inclined to say that this is an error in Octave's pkg function or the installer 
rather than in the windows package.

Markus