Re: dicom package maintainer

[Andy Buckle]

On 30 January 2017 at 17:21, JohnD <address@hidden> wrote:

> -----Original Message-----
> From: address@hidden [mailto:address@hidden] On Behalf Of
> Carnë Draug
> Sent: Sunday, January 29, 2017 10:20 AM
> To: John Donoghue
> Cc: Andy Buckle; Octave Maintainers List
> Subject: Re: dicom package maintainer
>
> On 29 January 2017 at 14:50, John Donoghue
> <address@hidden> wrote:
> > [...]
> > There are some test dcm files referenced within the .cpp source tests
> > - where are they, and can they be included in the package?
>
> I removed binary files when the packages were converted to mercurial.
> You can still get them from the svn repo [1] or you can use the hg copy of the
> whole svn [2].  The file will be at "extra/dicom/dcm_examples/RD.15MV.DCM"
>
> A set of dicom files for a thorough test suite may become quite large so I am
> not sure if it's a good idea to start adding them to the repository.  Maybe a
> repository with test datasets could be created and there could be optional tests
> that download the files as part of maintainer tests.  Such setup would also be
> handy for core and at least the io package.
>
> Carnë
>
> [1] svn://svn.code.sf.net/p/octave/code/trunk/octave-forge/
> [2] http://hg.octave.org/forge/

The gdcm project already has a repo for test data files [1] , so I can use that.

I can create a shared variable for the testname, download to tmp, run the tests and then delete the temp file on the last test

Unless there is  nicer way to cleanup after running the tests?

[1] https://sourceforge.net/p/gdcm/gdcmdata/ci/master/tree/

Most DICOM images are 2D. I had an example 3D dose file. The GDCM test file list looks quite long, and covers more odd cases than I ever did, but may not have a 3D file.

--

/* andy buckle */