Re: Is --enable-64 still experimental?

[chechu]

Good morning Carnë, thanks for your effort.

We had cloned the image stable branch from the repository and it build; the
downside is that bwlabeln and other functions are not yet included on 2.5.0+
image package.

We had tried to leave the spatial_filter.cc file in  2.4.0 image package as
your change proposed, deleting that two lines leaves the code as follows:

.........

else if (method == "entropy")
    {
      // Do the real work
      #define ACTION(MT, FUN, ET) \
              GENERAL_ACTION(MT, FUN, ET, NDArray, double, entropy_filt)
      if (args (0).is_bool_matrix ())
        ACTION (boolNDArray, bool_array_value, bool)
      else if (args (0).is_uint8_type ())
        ACTION (uint8NDArray, uint8_array_value, octave_uint8)
      else
        error ("__spatial_filtering__: first input should be a real,
complex, or integer array");

........
 -------------------

That change is not helping to compile the 2.4.0 octave-forge package, the
log is as follows :


__spatial_filtering__.cc:600:9:   required from here
__spatial_filtering__.cc:191:25: error: conversion from ‘octave_int<unsigned
char>’ to ‘octave_idx_type {aka long int}’ is ambiguous
     hist (vals (i) + add) ++;
                         ^
__spatial_filtering__.cc:191:25: note: candidates are:
In file included from
/usr/include/octave-4.0.0-rc3/octave/../octave/idx-vector.h:36:0,
                 from
/usr/include/octave-4.0.0-rc3/octave/../octave/Array.h:36,
                 from
/usr/include/octave-4.0.0-rc3/octave/../octave/boolMatrix.h:27,
                 from
/usr/include/octave-4.0.0-rc3/octave/../octave/mx-base.h:32,
                 from
/usr/include/octave-4.0.0-rc3/octave/../octave/Matrix.h:30,
                 from
/usr/include/octave-4.0.0-rc3/octave/../octave/oct.h:33,
                 from __spatial_filtering__.cc:21:
/usr/include/octave-4.0.0-rc3/octave/../octave/oct-inttypes.h:891:3: note:
octave_int<T>::operator float() const [with T = unsigned char]
   operator float (void) const { return float_value (); }
   ^
/usr/include/octave-4.0.0-rc3/octave/../octave/oct-inttypes.h:889:3: note:
octave_int<T>::operator double() const [with T = unsigned char]
   operator double (void) const { return double_value (); }
   ^
/usr/include/octave-4.0.0-rc3/octave/../octave/oct-inttypes.h:885:3: note:
octave_int<T>::operator T() const [with T = unsigned char]
   operator T (void) const { return value (); }

-----------

Thanks so much, your sincerely Jose






--
View this message in context: 
http://octave.1599824.n4.nabble.com/Is-enable-64-still-experimental-tp4669274p4670136.html
Sent from the Octave - Maintainers mailing list archive at Nabble.com.