|
From: | Marco Vassallo |
Subject: | Re: [fem-fenics] Build system |
Date: | Sun, 9 Mar 2014 01:05:43 +0000 |
Another aspect is that the configure script explicitly looks for the Eigen headers, whilst the package sources never explicitly include them. When using pkg-config these recursive dependencies are handled by the utility itself, so in my opinion the Eigen checks can be removed.
As a last consideration, even if the package now installs without setting manually the compilation flags, as already said they are still necessary for the just in time compilation, so probably a PKG_ADD with proper instructions should be provided.
If you agree with my points I am willing to work on them and provide further patches to address the issues these days.
[Prev in Thread] | Current Thread | [Next in Thread] |