|
From: | Michael Goffioul |
Subject: | Re: Question about Array::index with resizing |
Date: | Thu, 23 May 2013 11:23:40 -0400 |
Also through the "auto_add" parameter of the octave_value::subsref that was apparently added by Jaroslav. That's set to true in one case in tree_index_expression::lvalue.On 05/23/2013 01:15 AM, John W. Eaton wrote:
On 05/23/2013 12:39 AM, John W. Eaton wrote:
I can't see where these functions are actually used with resize_ok =
true. If that's actually the case, then I'd be happy to remove these
arguments.
I did some more digging and I do see that it is used in ov-class.cc, at
least.
Given the comments in Array.h:
// Indexing with possible resizing and fill
// FIXME -- this is really a corner case, that should better be
// handled directly in liboctinterp.
maybe we should fix libinterp now so that it handles the special cases and eliminate them from the Array class index functions?
[Prev in Thread] | Current Thread | [Next in Thread] |