Re: More New Functions: findfigs.m, isfloat.m, genvarname.m

[Robert Platt]

Sorry for not replying sooner, I was away on a course.

The version submitted by Bill assumes that the input strings are already
valid. e.g.:

genvarname('4example', '4example')
==> 4example1 --- invalid variable name

compared this to '_4example', which is generated by the other version.

Guaranteeing the variable names generated is an important feature of the
Matlab genvarname function. Are you happy to submit the other version of
genvarname, Bill?

Rob

John W. Eaton wrote:
> On 10-Mar-2008, Bill Denney wrote:
>
> | Attached are three new functions.  Essentially now I'm just going 
> | through the list of functions in matlab that are missing in octave and 
> | writing the low hanging fruit.
>
> | # HG changeset patch
> | # User address@hidden
> | # Date 1205199789 14400
> | # Node ID a04d848ac6c371575205cbc130ed75035f2e9e4b
> | # Parent  2e72daff62ba3d194850fff4e519d23a464c45e0
> | genvarname.m, isfloat.m, findfigs.m: new functions
>
> | +++ b/scripts/general/genvarname.m  Mon Mar 10 21:43:09 2008 -0400
>
> Another genvarname was just submitted.  See
>
>   https://www.cae.wisc.edu/pipermail/bug-octave/2008-March/005368.html
>
>   
<snip>
> Will you and Robert please reconcile your versions and submit a single
> function?
>
> Also, when you add new .m files, they need to be listed in the
> Makefile.in files where you add them.  It helps if that change is
> included in your patch.
>
> Thanks,
>
> jwe
>
>