[Octave-bug-tracker] [bug #61489] [octave forge] (octproj) Use string literal in call to error() and warning() functions

[Rafael Laboissiere]

URL:
  <https://savannah.gnu.org/bugs/?61489>

                 Summary: [octave forge] (octproj) Use string literal in call
to error() and warning() functions
                 Project: GNU Octave
            Submitted by: rlaboiss
            Submitted on: Mon 15 Nov 2021 06:22:02 PM UTC
                Category: Octave Forge Package
                Severity: 3 - Normal
                Priority: 5 - Normal
              Item Group: Other
                  Status: None
             Assigned to: None
         Originator Name: 
        Originator Email: 
             Open/Closed: Open
                 Release: other
         Discussion Lock: Any
        Operating System: GNU/Linux

    _______________________________________________________

Details:

Compilation of the octclip package with option -Werror=format-security (a
requirement for building Debian packages) fails with error messages like
this:


_op_fwd.cc: In function ‘octave_value_list F_op_fwd(const
octave_value_list&, int)’:
_op_fwd.cc:77:15: error: format not a string literal and no format arguments
[-Werror=format-security]
   77 |         error(errorText);
      |               ^~~~~~~~~
_op_fwd.cc:123:25: error: format not a string literal and no format arguments
[-Werror=format-security]
  123 |                 warning(errorText);
      |                         ^~~~~~~~~
_op_fwd.cc:139:23: error: format not a string literal and no format arguments
[-Werror=format-security]
  139 |                 error(errorText);
      |                       ^~~~~~~~~
cc1plus: some warnings being treated as errors
make[1]: *** [Makefile:25: compile] Error 1


The patch attached to this bug report fixes the issue.



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Mon 15 Nov 2021 06:22:02 PM UTC  Name: format-security-error.patch 
Size: 4KiB   By: rlaboiss

<http://savannah.gnu.org/bugs/download.php?file_id=52284>

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?61489>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/