octave-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #49653] Build failure with ImageMagick


From: John W. Eaton
Subject: [Octave-bug-tracker] [bug #49653] Build failure with ImageMagick
Date: Thu, 11 Nov 2021 14:08:35 -0500 (EST)
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0

Follow-up Comment #17, bug #49653 (project octave):

No, it doesn't.  I added -save-temps to the compiler flags, looked at the
resulting __magick_read__.ii file and eventually figured out that having
MAGICKCORE_HDRI_ENABLE defined to 1 was causing the trouble.  On my system,
which has libraries compiled with QuantumDepth == 16, I can get the build to
succeed with


diff --git a/libinterp/corefcn/__magick_read__.cc
b/libinterp/corefcn/__magick_read__.cc
--- a/libinterp/corefcn/__magick_read__.cc
+++ b/libinterp/corefcn/__magick_read__.cc
@@ -39,8 +39,13 @@
 #include "errwarn.h"
 
 #if defined (HAVE_MAGICK)
+#define MAGICKCORE_QUANTUM_DEPTH 16
+#define MAGICKCORE_HDRI_ENABLE 0
+
 #  include <Magick++.h>
 #  include <clocale>
+
+using MagickCore::Quantum;
 #endif
 
 OCTAVE_NAMESPACE_BEGIN


Now we need a way for Octave's configure script to detect the value of
QuantumDepth that the library uses so that we can set that in config.h instead
of as a magic value in __magick_read__.cc.  I'm not interested in working on
that but if someone else wants to do it I'll certainly consider patches.

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?49653>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]