[Octave-bug-tracker] [bug #59953] [octave forge] (image) imtransform xdata can't handle descending order

[Hartmut]

Follow-up Comment #8, bug #59953 (project octave):

Sorry for the late reply, I have now reviewd the latest patch (V2, the diff
file only) from Avinoam:

* all tests still pass
* the demo still works
* the patched imtransform returns the Matlab compatible values for the code
mentioned originally (comment #0) in this bug report.
* there are new tests added for this new functionality
* the coding guidelines are mostly fulfilled, some things that COULD maybe
improved (but this is mostly only taste):
** add a space sign after each semicolon in the definition of "im" in the new
test. Maybe also do this for the manually typed matrices in the final assert
statements in the new test.
** maybe add an empty line after the new line 188, i.e. after the new (and
commented) code piece.
* There are some spelling errors the should probably be fixed before pushing:
** The mistyped word "vetical" shouls probably read "vertical".
** in the doc text: the formulation "which cause" should probably read "which
causes".

After probably fixing the small typos in the doc strings, I would like to see
this patch pushed to the image repo. Thanks for fixing this bug, Avinoam.

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?59953>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/