[Octave-bug-tracker] [bug #61393] [octave forge] (sparsersb) Crash while "pkg test sparsersb"

[Markus Mützel]

URL:
  <https://savannah.gnu.org/bugs/?61393>

                 Summary: [octave forge] (sparsersb) Crash while "pkg test
sparsersb"
                 Project: GNU Octave
            Submitted by: mmuetzel
            Submitted on: Wed 27 Oct 2021 10:45:08 AM CEST
                Category: Octave Forge Package
                Severity: 3 - Normal
                Priority: 5 - Normal
              Item Group: Segfault, Bus Error, etc.
                  Status: None
             Assigned to: None
         Originator Name: 
        Originator Email: 
             Open/Closed: Open
                 Release: other
         Discussion Lock: Any
        Operating System: Microsoft Windows

    _______________________________________________________

Details:

With the release candidate of Octave (version 6.3.90), running `pkg test
sparsersb` crashes Octave if the sparsersb package was installed to a
read-only directory.

The content that is written to `fntests.log` up to the crash:

>>>>> processing C:\Program Files\GNU
Octave\Octave-6.3.90\mingw64\lib\octave\packages\sparsersb-1.0.9\x86_64-w64-mingw32-api-v56\sparsersb.cc-tst
***** test
 s=sparsersb([1]);
 sparsersb(sparsersb([11,0;21,22]),"save","sparsersb_temporary_matrix_file.mtx")
!!!!! test failed
librsb error: An unspecified error occurred.
***** test
 [S, NROWS, NCOLS, NNZ, REPINFO, FIELD, SYMMETRY] =
sparsersb("sparsersb_temporary_matrix_file.mtx"     );
 assert(NROWS==2)
 assert(NCOLS==2)
 assert(NNZ==3)
 assert(FIELD=="real");
 assert(SYMMETRY=='U');
!!!!! test failed
element number 1 undefined in return list
***** test
 [S, NROWS, NCOLS, NNZ, REPINFO, FIELD, SYMMETRY] =
sparsersb("sparsersb_temporary_matrix_file.mtx", "Z");
 assert(NROWS==2);
 assert(NCOLS==2);
 assert(NNZ==3);
 assert(FIELD=="complex");
 assert(SYMMETRY=='U');
!!!!! test failed
element number 1 undefined in return list
***** test
 [S, NROWS, NCOLS, NNZ, REPINFO, FIELD] =
sparsersb("sparsersb_temporary_matrix_file.mtx", "D");
 assert(NROWS==2);
 assert(NCOLS==2);
 assert(NNZ==3);
 assert(FIELD=="real");
!!!!! test failed
element number 1 undefined in return list
***** test
 [S, NROWS, NCOLS, NNZ, REPINFO] =
sparsersb("sparsersb_temporary_matrix_file.mtx", "D");
 assert(NROWS==2);
 assert(NCOLS==2);
 assert(NNZ==3);
!!!!! test failed
element number 1 undefined in return list
***** test
 [S, NROWS, NCOLS] = sparsersb("sparsersb_temporary_matrix_file.mtx", "D");
 assert(NROWS==2);
 assert(NCOLS==2);
!!!!! test failed
element number 1 undefined in return list
***** test
 [S, NROWS] = sparsersb("sparsersb_temporary_matrix_file.mtx", "D");
 assert(NROWS==2);
!!!!! test failed
element number 1 undefined in return list


The current directory during the tests is the path where the tests are
installed. That is a read-only directory by default for the bundled version
(global package) of sparsersb on Windows.
The original error seems to be that the file
"sparsersb_temporary_matrix_file.mtx" cannot be created in the read-only
directory.

A possible fix for that issue might be to create the file in the TEMP
directory. The command that writes the file could be changed to e.g.:

sparsersb(sparsersb([11,0;21,22]),"save",fullfile(tempdir(),"sparsersb_temporary_matrix_file.mtx"))


The tests that access that file would need to be adapted accordingly.

Additionally, `sparsersb` probably shouldn't cause a crash if the file it
tries to open doesn't exist.

I set the OS to "MS Windows" because that is where I noticed the error. But
something similar would probably also occur on other platforms.




    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?61393>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/