[Octave-bug-tracker] [bug #61370] gcc's thread sanitizer reports several race conditions

[anonymous]

URL:
  <https://savannah.gnu.org/bugs/?61370>

                 Summary: gcc's thread sanitizer reports several race
conditions
                 Project: GNU Octave
            Submitted by: None
            Submitted on: Sat 23 Oct 2021 10:23:45 AM UTC
                Category: Interpreter
                Severity: 3 - Normal
                Priority: 5 - Normal
              Item Group: Unexpected Error or Warning
                  Status: None
             Assigned to: None
         Originator Name: Reinhard
        Originator Email: octave-user@a1.net
             Open/Closed: Open
                 Release: 6.3.0
         Discussion Lock: Any
        Operating System: GNU/Linux

    _______________________________________________________

Details:

Dear GNU/Octave developers,

If I compile the stable branch of Octave using -fsanitize=thread, I get
several warnings about race conditions. 
For example if I configure octave using the following options

./configure --prefix=/opt/octave-tsan LDFLAGS=-Wl,-rpath=/usr/local/lib
--with-blas=-L/usr/local/lib -lopenblas --with-lapack=-L/usr/local/lib
-lopenblas CXXFLAGS=-g -fsanitize=thread -Wall -O2 -march=native
CFLAGS=-march=native -Wall -O2 -g -fsanitize=thread FFLAGS=-march=native -Wall
-O2 -g -fsanitize=thread FCFLAGS=-march=native -Wall -O2 -g -fsanitize=thread

and execute 

src/octave-cli

and then type Ctrl+C several times, I already get some warnings about race
conditions. I have attached a patch for the stable branch which fixes most of
it, at least in case of octave-cli. I did not check octave-gui since it would
be required to rebuild the Qt5 library with -fsanitize=thread.
So far, I have executed all tests and there are no regressions when applying
the patch.
If you want, I can port those patch to the default branch.

Best regards,
Reinhard



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Sat 23 Oct 2021 10:23:45 AM UTC  Name: octave-fix-race-conditions.patch 
Size: 7KiB   By: None

<http://savannah.gnu.org/bugs/download.php?file_id=52147>

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?61370>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/