[Octave-bug-tracker] [bug #61030] [octave forge] (image) Don't use internal function

[Hartmut]

Follow-up Comment #5, bug #61030 (project octave):

I am not very fluent in C, but I would like to see the following formal
changes, or have the following formal checks done and reported here, before
pushing this patch:

* improve the wording of the commit message of the patch, e.g. mention the bug
report number, and list the file names of all touched source code files. All
as usual.

* name Markus Mützel as author of this patch in the commit (as long as we
mostly just copy his code changes over to the image repo).

* Please check that the image package still compiles in all core Octave
versions that we currently still support. (I assume that it compiles fine in
current dev Octave, since the Octave CI setups don't complain. But does it
also compile fine in Octave version 4.2.0, the oldest Octave core version
still supported by the image package?)

* Please check that the corresponding BISTs all still pass (at least the BISTs
for the three files touched, and at least for Octave 4.2.0. Probably also in
Octave 6.3.0 and 5.2.0 and 4.4.1)

* Ideally (but optionally) do a small check if there is a (significant)
run-time increase with this code change. If yes, we probably cannot do
anything about it, it would just be nice to know.

I have recently done a full OS re-installation on my laptop, and won't be able
to do those tests on my own machine in a reasonable time frame.

Soon I will also be offline for a couple of weeks. But as soon as the above
items are check, I would be happy if someone (Avinoam?) pushes this patch to
the repo.

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?61030>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/