[Octave-bug-tracker] [bug #60636] Build error in QWinTerminalImpl

[Markus Mützel]

URL:
  <https://savannah.gnu.org/bugs/?60636>

                 Summary: Build error in QWinTerminalImpl
                 Project: GNU Octave
            Submitted by: mmuetzel
            Submitted on: Wed 19 May 2021 11:05:17 AM CEST
                Category: GUI
                Severity: 3 - Normal
                Priority: 5 - Normal
              Item Group: Build Failure
                  Status: None
             Assigned to: None
         Originator Name: 
        Originator Email: 
             Open/Closed: Open
                 Release: dev
         Discussion Lock: Any
        Operating System: Microsoft Windows

    _______________________________________________________

Details:

The buildbot builders for Windows targets are failing with the following in
the logs:

[build]    default-octave
Failed to build package default-octave!
------------------------------------------------------------
      |                                                             ^
In file included from
/scratch/buildbot/workers/jwe-debian-x86_64-0/w32-on-debian/src/tmp-default-octave/octave-7.0.0/libgui/qterminal/libqterminal/win32/QWinTerminalImpl.h:27,
                 from
/scratch/buildbot/workers/jwe-debian-x86_64-0/w32-on-debian/src/tmp-default-octave/octave-7.0.0/libgui/qterminal/libqterminal/win32/QWinTerminalImpl.cpp:56:
/scratch/buildbot/workers/jwe-debian-x86_64-0/w32-on-debian/src/tmp-default-octave/octave-7.0.0/libgui/qterminal/libqterminal/QTerminal.h:141:3:
note: candidate: 'QTerminal::QTerminal(octave::base_qobject&, QWidget*)'
  141 |   QTerminal (octave::base_qobject& oct_qobj, QWidget *xparent =
nullptr)
      |   ^~~~~~~~~
/scratch/buildbot/workers/jwe-debian-x86_64-0/w32-on-debian/src/tmp-default-octave/octave-7.0.0/libgui/qterminal/libqterminal/QTerminal.h:141:36:
note:   no known conversion for argument 1 from 'QWidget*' to
'octave::base_qobject&'
  141 |   QTerminal (octave::base_qobject& oct_qobj, QWidget *xparent =
nullptr)
      |              ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
make[4]: *** [Makefile:18268:
libgui/qterminal/libqterminal/win32/la-QWinTerminalImpl.lo] Error 1
make[4]: *** Waiting for unfinished jobs....


I'd guess this is caused by this constructor:

QWinTerminalImpl::QWinTerminalImpl (const QString& cmd, QWidget* parent)
    : QTerminal (parent), d (new QConsolePrivate (this, cmd))
{
}


"QTerminal (parent)" is no longer a valid constructor signature.
The failing constructor for "QWinTerminalImpl" doesn't seem to be used
anywhere. Can we just remove it?





    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?60636>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/