[Octave-bug-tracker] [bug #60465] [octave forge] (signal) findpeaks should plot data

[Mike Miller]

Follow-up Comment #3, bug #60465 (project octave):

Still some room for improvement if you want to continue working on this.

* Please try to avoid calling findpeaks recursively and re-indenting the
entire file. Instead, keep the main body of the function the same, and just
group and avoid the assignment to the output arguments if nargout is zero. See
other plotting functions for multiple examples of this programming pattern.

* If a figure is already open, what should findpeaks do? Should it reuse the
current figure and overwrite whatever the user had already plotted there? Or
should it always create a new figure and new axes object and plot there? What
does Matlab do? From my limited testing, seems like Matlab plots into the
current axes, respects and maintains the current hold state and line color
sequence, but it does force the axis limits to be what it wants for the given
data sequence.

* I think it would be better to combine the 'plot' and 'scatter' into one
'plot' function call, and avoid the 'hold on'. It should also use the current
line color, instead of [0 0 1].

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?60465>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/