[Octave-bug-tracker] [bug #60535] malloc bug in unistd-wrappers.c

[John W. Eaton]

Follow-up Comment #2, bug #60535 (project octave):

Instead of


new_argv = malloc ((argc + 1) * sizeof (*new_argv));


I would write


new_argv = (char **) malloc ((argc + 1) * sizeof (char *));


(though I suppose we could do away with the cast on the value returned from
malloc since this is C code).

I would not change the other allocation because sizeof (char) is always 1 by
definition, though I can also see the argument for using sizeof the way you
did.  I'm not sure what is best here, but I don't recall seeing that style
used before.

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?60535>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/