[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-bug-tracker] [bug #55538] logspace BIST tests fail when Octave b
From: |
Markus Mützel |
Subject: |
[Octave-bug-tracker] [bug #55538] logspace BIST tests fail when Octave built with LLVM libc++ |
Date: |
Sat, 1 May 2021 09:27:44 -0400 (EDT) |
User-agent: |
Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/90.0.4430.85 Safari/537.36 Edg/90.0.818.49 |
Follow-up Comment #3, bug #55538 (project octave):
The attached patch duplicates the affected tests and marks them as a known
error on macOS.
Is this the coding pattern that we would like to use for tests that are known
to fail on some platforms?
Some caveats with this patch:
IIUC, it isn't clear if libstdc++ or libc++ returns the expected values here.
FWIW, the results with Matlab R2021a on Windows:
>> logspace (Inf + 1i, Inf + 1i, 3)
ans =
-Inf + Infi -Inf + Infi -Inf + Infi
>> logspace (-Inf + 1i, Inf + 1i, 3)
ans =
0.0000 + 0.0000i NaN + NaNi -Inf + Infi
For all I know, their results could be different on macOS as well.
The real condition should be whether Octave was linked with libc++. Since this
is the default on macOS, and most other platforms are probably linking with
libstdc++, conditioning the tests on `ismac ()` will probably cover most cases
correctly.
(file #51349)
_______________________________________________________
Additional Item Attachment:
File name: bug55538_logspace_macOS.patch Size:1 KB
<https://file.savannah.gnu.org/file/bug55538_logspace_macOS.patch?file_id=51349>
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?55538>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
- [Octave-bug-tracker] [bug #55538] logspace BIST tests fail when Octave built with LLVM libc++,
Markus Mützel <=