octave-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #59850] uniquetol missing, so I implemented it


From: anonymous
Subject: [Octave-bug-tracker] [bug #59850] uniquetol missing, so I implemented it
Date: Sun, 24 Jan 2021 04:30:27 -0500 (EST)
User-agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:72.0) Gecko/20100101 Firefox/72.0

Follow-up Comment #15, bug #59850 (project octave):

Implemented a fast version of uniquetol for when byrows is false. My timing
for Rik's example is around 0.02 seconds which makes the implementation faster
than Matlab (assuming our computers are the same).

I made minor changes elsewhere, ia and ic are now always column vectors
regardless of the orientation of the input excluding when a cell array is
returned then the cell is a row and the elements within are columns. This
makes the output consistent with the current documentation. This
implementation also naturally fixed the sorting difference between the
previous version and Matlab.

I also changed the unique 'see also' to include uniquetol.

I have attached two patches generated from TortoiseHg.

A note about TortoiseHg in the installation process it replaces files in
Microsoft Visual C++ 2015-2019 Redistributable (x64) with older versions of
those files which resulted in other software I frequently use to stop working.
Uninstalling TortoiseHg does not solve the problem. However, going to add
remove programs and clicking remove then repair on Microsoft Visual C++
2015-2019 Redistributable (x64) fixes the issue and does not appear to break
TortoiseHg.



(file #50774, file #50775)
    _______________________________________________________

Additional Item Attachment:

File name: 29313.patch                    Size:4 KB
    <https://file.savannah.gnu.org/file/29313.patch?file_id=50774>

File name: 29314.patch                    Size:0 KB
    <https://file.savannah.gnu.org/file/29314.patch?file_id=50775>



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?59850>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]