[Octave-bug-tracker] [bug #56065] New function "contains"

[Markus Mützel]

Follow-up Comment #6, bug #56065 (project octave):

Thank you for your contribution and sorry it took so long until a review.

I haven't actually tested the new function. But a few preliminary comments to
the latest patch file #48549 (some or most of them are nitpicking. Sorry for
that.):
- The file has the wrong name (in the patch).
- The copyright says 2008-2020. But that file isn't from 2008.
- There are some spelling and grammar errors in the doc string.
- We usually have the input check as a first block before the "actual
functionality".
- Also the input check seems to be incomplete. Instead of "iscell", you should
probably use "iscellstr". The third input argument is ignored.
- Use parenthesis around if-conditions.
- Prefer to use double quoted strings.
- Use spaces between function name and opening parenthesis (in BISTs and
example in docstring).
- Add ids to errors. (That one is new.)
- Use "!" not "~" for negation.
- Add new file to build system (module.mk).
- Add note about new file to NEWS file.

I started to correct those issues when I realized that the BISTs and examples
are copies from Matlab's documentation for that function. I'm not sure it is
legal to use those.

It would be nice if you could change those to less problematic examples.

Please, use the attached work-in-progress patch if possible.

(file #50029)
    _______________________________________________________

Additional Item Attachment:

File name: bug56065_contains_v2.patch     Size:5 KB
   
<https://file.savannah.gnu.org/file/bug56065_contains_v2.patch?file_id=50029>



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?56065>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/