[Octave-bug-tracker] [bug #57867] strrep: unexpected substitution behavior on a char array

[Nicholas Jankowski]

Follow-up Comment #62, bug #57867 (project octave):

First, I notice that this patch still didn't add any tests to verify the
bugfix.  But more importantly, that patch doesn't even apply to my copy of the
source code:


$ hg patch --no-commit ../mypatch8.patch
applying ../mypatch8.patch
patching file libinterp/corefcn/strfind.cc
Hunk #1 FAILED at 441
Hunk #2 FAILED at 469
2 out of 2 hunks FAILED -- saving rejects to file
libinterp/corefcn/strfind.cc.rej
abort: patch failed to apply



I'm noticing some leading whitespace issues in the first line to be removed
deleted. (patch line 16)  That whitespace isn't there in strfind or in your
previous patch.  

and your 2nd hunk (line 47) is showing line 469 (starting with retval) rather
than the 470 (starting with else). I would have thought that would have
applied with a 1 line offset, not sure why it failed outright. But it doesn't
look like anyone else has made a change to strfind.cc in between your two
patches.  

Are you manually editing the patch file? Or making changes not included in
your patch? I'm not sure how else you would get those type of changes. 




    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?57867>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/