[Octave-bug-tracker] [bug #57867] strrep: unexpected substitution behavior on a char array

[Nicholas Jankowski]

Follow-up Comment #29, bug #57867 (project octave):

thank you for that patch file.  that is definitely a step in the right
direction.  Please continue to use patches like that to contribute changes.

some thoughts:

- should there be any changes to the help text so the user understands any
changed behavior

- you should add a few self tests to the function that verify your new code
produces the correct output.  (these are the lines at the end of the file
starting with %!assert and %!error, so that the function can be tested with 

>> test strrep

and to verify that none of the other functions have been broken.

- if no other files need to be edited, you could follow the 1-line commit
message guidelines from 
https://wiki.octave.org/Commit_message_guidelines

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?57867>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/