[Octave-bug-tracker] [bug #57049] Mac build failure: CFLocaleCopyCurrent from CoreFoundation not found

[Andrew Janke]

Follow-up Comment #27, bug #57049 (project octave):

Okay, I tried a few approaches, and most of them worked (insofar as getting
the build to succeed and I don't see any new obvious failures in the test
suite).

I like @mmuetzel's approach of adding $INTL_MACOSX_LIBS to $GNULIB_LINK_DEPS
and $MKOCTFILE_GNULIB_LINK_DEPS in configure.ac the best. It feels "righter"
to me at that level. And the note from gnulib's `./bootstrap` says:


Use them in <program>_LDADD when linking a program, or
in <library>_a_LDFLAGS or <library>_la_LDFLAGS when linking a library.


In liboctave/module.mk, $(LIBOCTAVE_LINK_DEPS) is propagated to
%canon_reldir%_%canon_reldir%_la_LIBADD, which I think is our equivalent of
"<program_>LDADD" here. So that seems right-ish.

Here's a patch: https://savannah.gnu.org/bugs/download.php?file_id=47800.
Works for me both under `brew` and a regular build, on macOS 10.14.6.

@cdf, can you test that patch out and see if it works for you too?

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?57049>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/